[spaceship] Update sinatra to 2.x (uses rack 2.x) #16776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
The sinatra usage in this project is easy enough that it didn't need any changes when updating. While being on the latest release should be reason enough, there is one nice thing implicitly done here (not shown since no
Gemfile.lock
is being committed), is thatrack
is now also at~> 2.0
, which receives updates and security fixes (although most were backported to 1.6.x).Description
No real description, but some CHANGELOG.md files to see what changed.
https://github.com/sinatra/sinatra/blob/master/CHANGELOG.md
https://github.com/rack/rack/blob/master/CHANGELOG.md
Example of a backported CVE fix.
https://nvd.nist.gov/vuln/detail/CVE-2019-16782